Fix invalid directory for dnsmasq files in asuswrt#33503
Merged
balloob merged 1 commit intohome-assistant:devfrom Apr 1, 2020
Merged
Fix invalid directory for dnsmasq files in asuswrt#33503balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
|
Hey there @kennedyshead, mind taking a look at this pull request as its been labeled with a integration ( |
Member
Author
|
Since I was the one who suggested this change here I feel obligated to fix this 😄 |
Contributor
|
What is the meaning of this change? I create a PR for AsusWRT component and now the validation check fail on this test. |
Member
|
@ollo69 If there is an issue, please open up an issue (you can refer to other PRs in the issue report). |
Contributor
|
Sorry, my mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Incorrect config validation helper was used to verify the existence of the directory for dnsmasq files. However, this helper cannot be used since it is restricted to local files/directories. This is not the case here because the dnsmasq files are stored on the router.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: